Skip to content

Conversation

@Rexicon226
Copy link
Contributor

No description provided.

@github-project-automation github-project-automation bot moved this to 🏗 In progress in Sig Sep 10, 2025
@Rexicon226 Rexicon226 force-pushed the Rexicon226/zksdk-refactor branch from 8250cf9 to 3f092e1 Compare September 10, 2025 01:36
@Rexicon226 Rexicon226 force-pushed the Rexicon226/zksdk-refactor branch from 3f092e1 to 81fee7d Compare September 10, 2025 01:37
@Rexicon226 Rexicon226 self-assigned this Sep 10, 2025
@Rexicon226 Rexicon226 force-pushed the Rexicon226/zksdk-refactor branch 2 times, most recently from 3e9bbe5 to fdcc161 Compare September 16, 2025 06:51
@Rexicon226 Rexicon226 changed the base branch from main to graphite-base/942 September 23, 2025 16:06
@Rexicon226 Rexicon226 force-pushed the Rexicon226/zksdk-refactor branch from c364c5e to 573dd60 Compare September 23, 2025 16:06
@Rexicon226 Rexicon226 changed the base branch from graphite-base/942 to Rexicon226/fuzzcorp September 23, 2025 16:06
Copy link
Contributor Author

Rexicon226 commented Sep 23, 2025

@Rexicon226 Rexicon226 force-pushed the Rexicon226/zksdk-refactor branch from 573dd60 to bd20cc3 Compare September 23, 2025 17:06
Base automatically changed from Rexicon226/fuzzcorp to main September 25, 2025 21:55
@Rexicon226 Rexicon226 force-pushed the Rexicon226/zksdk-refactor branch from bd20cc3 to d8b3db7 Compare September 26, 2025 15:07
yewman
yewman previously approved these changes Sep 29, 2025
@yewman yewman self-requested a review September 29, 2025 09:49
Copy link
Contributor

@yewman yewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, do you know what is causing the conformance issues?

@Rexicon226
Copy link
Contributor Author

Yes, it has to do with core-bpf being enabled for the stake program in the test-vectors, seems we aren't correctly doing something in that area. Haven't looked into it further yet, think @kprotty was going to?

@Rexicon226 Rexicon226 force-pushed the Rexicon226/zksdk-refactor branch from d8b3db7 to 38cb0bd Compare October 2, 2025 19:30
@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

❌ Patch coverage is 98.65255% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/shred_network/shred_verifier.zig 0.00% 8 Missing ⚠️
src/vm/syscalls/cpi.zig 40.00% 3 Missing ⚠️
src/crypto/ed25519/pippenger.zig 96.66% 1 Missing ⚠️
src/runtime/program_loader.zig 83.33% 1 Missing ⚠️
...ksdk/sigma_proofs/grouped_ciphertext/handles_2.zig 98.41% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/benchmarks.zig 50.00% <ø> (ø)
src/consensus/vote_listener.zig 92.31% <100.00%> (ø)
src/core/entry.zig 95.19% <100.00%> (ø)
src/core/poh.zig 98.92% <100.00%> (ø)
src/core/pubkey.zig 100.00% <100.00%> (ø)
src/core/signature.zig 85.00% <100.00%> (+3.75%) ⬆️
src/core/status_cache.zig 100.00% <100.00%> (ø)
src/core/transaction.zig 91.59% <100.00%> (ø)
src/crypto/bn254/fields.zig 99.23% <ø> (ø)
src/crypto/bn254/lib.zig 97.59% <100.00%> (+<0.01%) ⬆️
... and 35 more

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

yewman
yewman previously approved these changes Oct 7, 2025
Copy link
Contributor

@yewman yewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

InKryption
InKryption previously approved these changes Oct 7, 2025
@github-project-automation github-project-automation bot moved this from 🏗 In progress to 👀 In review in Sig Oct 7, 2025
Implements EdDSA with the avx2/avx512 ed25519 implementations, resulting
in a 2.8x speedup. The speedup is also in part to a slightly faster
straus implementation than the one the zig stdlib uses, since it can be
variable time + different radix setup.

```
+------------------+-------+-------+-------+----------+
| naiveBatchVerify |  min  |  max  |  mean |  std_dev |
+==================+=======+=======+=======+==========+
| _                |  3719 |  5888 |  3863 |  186     |
+------------------+-------+-------+-------+----------+
+----------------+-------+-------+-------+----------+
| stdBatchVerify |  min  |  max  |  mean |  std_dev |
+================+=======+=======+=======+==========+
| _              |  1579 |  2510 |  1625 |  73      |
+----------------+-------+-------+-------+----------+
+----------------+-------+-------+-------+----------+
| sigBatchVerify |  min  |  max  |  mean |  std_dev |
+================+=======+=======+=======+==========+
| _              |  1315 |  2107 |  1349 |  45      |
+----------------+-------+-------+-------+----------+
```

Unfortunately it is not currently possible to fully batch transaction
verification. Agave loops over transaction signatures and
`verify_strict`s each one, in order to tighten down on the behaviour
regarding low-order points. While this makes some sense, in reality it
greatly reduces our ability to do sigverify fast, and doesn't really
have any benefit to the protocol. Wish Solana could use something like
ed25519-zebra instead.
@Rexicon226 Rexicon226 dismissed stale reviews from InKryption and yewman via f5482b2 October 7, 2025 18:22
@yewman yewman self-requested a review October 7, 2025 18:23
Copy link
Contributor

@yewman yewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Rexicon226 Rexicon226 enabled auto-merge October 7, 2025 18:51
@Rexicon226 Rexicon226 added this pull request to the merge queue Oct 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 7, 2025
@Rexicon226 Rexicon226 added this pull request to the merge queue Oct 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 8, 2025
@Rexicon226 Rexicon226 added this pull request to the merge queue Oct 8, 2025
Merged via the queue into main with commit 6382d36 Oct 8, 2025
18 checks passed
@Rexicon226 Rexicon226 deleted the Rexicon226/zksdk-refactor branch October 8, 2025 07:01
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Sig Oct 8, 2025
@Rexicon226 Rexicon226 restored the Rexicon226/zksdk-refactor branch October 8, 2025 07:09
@Rexicon226 Rexicon226 deleted the Rexicon226/zksdk-refactor branch October 31, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

5 participants